[Dependency Scanning] Bridge Clang dependency scanner results on-demand #83600
Conversation
artemcm
requested review from
cachemeifyoucan,
zoecarver,
egorzhdan,
beccadax,
ian-twilightcoder,
Xazax-hun,
j-hui,
fahadnayyar,
susmonteiro,
hborla,
slavapestov,
xedin and
xymus
as code owners
|
@swift-ci smoke test |
artemcm
force-pushed
the
NoRedundantClangDepBridging
branch
from
f345188 to
4876b2f
Compare
|
@swift-ci smoke test |
artemcm
force-pushed
the
NoRedundantClangDepBridging
branch
from
4876b2f to
8cf2714
Compare
|
@swift-ci smoke test |
| clang::tooling::dependencies::ModuleOutputKind)>; | ||
|
|
||
| ModuleDependencyInfo | ||
| bridgeClangModuleDependency( |
There was a problem hiding this comment.
This can be a static method as implementation details.
Or maybe it can be a private method in DependencyScanner? The callbacks all have a capture of the scanner reference, which is probably fine since scanner should outlive everything but if the bridging callbacks are part of the scanner, then there is no need for callback or worry about lifetimes.
There was a problem hiding this comment.
This required a bigger refactor than it originally seemed, but I moved the bridging code into a private scanner utility.
|
@swift-ci smoke test |
1 similar comment
|
@swift-ci smoke test |
|
@swift-ci smoke test Linux platform |
| @@ -163,6 +164,12 @@ using ModuleDependencyIDSetVector = | |||
| llvm::SetVector<ModuleDependencyID, std::vector<ModuleDependencyID>, | |||
| std::set<ModuleDependencyID>>; | |||
|
|
|||
| /// A callback to lookup module outputs for "-fmodule-file=", "-o" etc. | |||
There was a problem hiding this comment.
Those are left over from previous change? Those are not used in this header.
There was a problem hiding this comment.
Moved to ModuleDependencyScanner.h where the uses are.
| /// \returns \c true if an error occurred, \c false otherwise | ||
| bool scanHeaderDependenciesOfSwiftModule( | ||
| const ASTContext &ctx, | ||
| /// of a Swift module. |
There was a problem hiding this comment.
Why the Doxygen comments are removed?
Instead of always bridging all of the discovered modules of all of the queries, only do so for modules which are not already cached
artemcm
force-pushed
the
NoRedundantClangDepBridging
branch
from
36ea30d to
d228d30
Compare
|
@swift-ci smoke test |
…leDependencyScanner' utility This moves the functionality of 'bridgeClangModuleDependency' into a utility in the main scanner class because it relies on various objects whose lifetime is already tied to the scanner itself.
artemcm
force-pushed
the
NoRedundantClangDepBridging
branch
from
d228d30 to
9f0083c
Compare
|
@swift-ci smoke test |
#83050 changed the behavior to query every Clang module identifier imported from Swift, even for modules which may have previously been discovered as transitive dependencies of another query. This means we now have a lot of results coming in from Clang scanner queries which are redundant, and we bridge them all, all of the time, which adds up to a substantial amount of time.
Instead of always bridging all of the discovered modules of all of the queries, only do so for modules which have not already been cached at the time we record query results.